-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications via Shoutrrr #2994
Comments
Hi there! Shoutrrr sounds great! Would you be interested in sending a PR? I'd be glad to assist. Tom |
Yes! I don't have much experience with Go, but one always has to start somewhere :) |
hmoffatt
added a commit
to hmoffatt/dnscontrol
that referenced
this issue
Nov 27, 2024
hmoffatt
added a commit
to hmoffatt/dnscontrol
that referenced
this issue
Nov 27, 2024
Hey @kytta want to try out this on my PR? |
hmoffatt
added a commit
to hmoffatt/dnscontrol
that referenced
this issue
Dec 3, 2024
hmoffatt
added a commit
to hmoffatt/dnscontrol
that referenced
this issue
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, there is a limited number of notification types. Adding a new one is simple, but each notification type would require their own configuration parameters. Sometimes it's a token, sometimes it's a URL, sometimes it's both.
Describe the solution you'd like
We could consider using Shoutrrr, which is a Go library for notifications. Unlike the current solution, it uses a single URL for a notification type, and this URL encodes all information needed, be it tokens or other metadata. It supports all current notification types natively except for Bonfire, but since it also has webhook support, Bonfire is also easy to implement.
Describe alternatives you've considered
An obvious alternative would be to implement all notification types from scratch
Additional context
N/A
The text was updated successfully, but these errors were encountered: