Skip to content

Commit ba85bf2

Browse files
authored
Merge pull request #1010 from enykeev/update_node
Update Node version to current
2 parents 41d7540 + 712c721 commit ba85bf2

9 files changed

+30
-27
lines changed

.circleci/config.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ jobs:
3535
set +e
3636
export NVM_DIR="/opt/circleci/.nvm"
3737
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"
38-
nvm install 14.20.1
39-
nvm alias default v14.20.1
38+
nvm install 20.8.1
39+
nvm alias default v20.8.1
4040
4141
# Each step uses the same `$BASH_ENV`, so need to modify it
4242
echo 'export NVM_DIR="/opt/circleci/.nvm"' >> $BASH_ENV
@@ -59,18 +59,18 @@ jobs:
5959
sudo apt-get update
6060
sudo apt-get install rpm jq devscripts debhelper
6161
gem install package_cloud
62-
nvm use 14.20.1
62+
nvm use 20.8.1
6363
npm install --global [email protected] yarn
6464
- run:
6565
name: Install package dependencies
6666
command: |
67-
nvm use 14.20.1
67+
nvm use 20.8.1
6868
lerna bootstrap
6969
7070
- run:
7171
name: Run unit tests
7272
command: |
73-
nvm use 14.20.1
73+
nvm use 20.8.1
7474
npm run test-unit
7575
7676
- run:
@@ -129,13 +129,13 @@ jobs:
129129
- run:
130130
name: Make deb packages
131131
command: |
132-
nvm use 14.20.1
132+
nvm use 20.8.1
133133
make deb
134134
echo $DEB | tr ' ' '\n' | xargs -I{} cp -vr ../st2web_*.{deb,changes} ~/artifacts/{}
135135
- run:
136136
name: Make RPM packages
137137
command: |
138-
nvm use 14.20.1
138+
nvm use 20.8.1
139139
make rpm
140140
echo $RPM | tr ' ' '\n' | xargs -I{} cp -vr ../st2web-*.rpm ~/artifacts/{}
141141
- store_artifacts:

CHANGELOG.rst

+4
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ Changed
1010

1111
Contributed by @enykeev
1212

13+
* Updated NodeJS to v20 current (security). #1010
14+
15+
Contributed by @enykeev
16+
1317
Fixed
1418
~~~~~
1519
* Fixed CircleCI tests by pinning [email protected]. #1008

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:14.20.1
1+
FROM node:20.8.1
22

33
# Create app directory
44
WORKDIR /opt/stackstorm/static/webui/st2web

Dockerfile-dev

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:14.20.1
1+
FROM node:20.8.1
22

33
# Create app directory
44
WORKDIR /opt/stackstorm/static/webui/st2web

Dockerfile-nginx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:14.20.1 as build
1+
FROM node:20.8.1 as build
22

33
# Create app directory
44
WORKDIR /opt/stackstorm/static/webui/st2web

Dockerfile-nginx-dev

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:14.20.1 as build
1+
FROM node:20.8.1 as build
22

33
# Create app directory
44
WORKDIR /opt/stackstorm/static/webui/st2web

README.md

+8-9
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,18 @@ Quick start
1212
First of all, you need to make sure you have `node` and `npm` packages installed. Currently, we consider Node v14.x.x to be our stable.
1313

1414
```shell
15-
$ n 14
16-
17-
install : node-v14.17.0
18-
mkdir : /usr/local/n/versions/node/14.17.0
19-
fetch : https://nodejs.org/dist/v14.17.0/node-v14.17.0-darwin-x64.tar.gz
20-
######################################################################## 100.0%
21-
installed : v14.17.0
15+
$ n 20
16+
installing : node-v20.8.1
17+
mkdir : /home/enykeev/n/n/versions/node/20.8.1
18+
fetch : https://nodejs.org/dist/v20.8.1/node-v20.8.1-linux-x64.tar.xz
19+
copying : node/20.8.1
20+
installed : v20.8.1 (with npm 10.1.0)
2221

2322
$ node -v
24-
v14.17.0
23+
v20.8.1
2524

2625
$ npm -v
27-
6.14.13
26+
10.1.0
2827
```
2928

3029
then you need to globally install `gulp`, `lerna` and `yarn`

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
},
2020
"repository": "stackstorm/st2web",
2121
"engines": {
22-
"node": "14.20.1",
23-
"npm": "6.14.12"
22+
"node": "20.8.1",
23+
"npm": "10.1.0"
2424
},
2525
"browserify": {
2626
"transform": [
@@ -79,7 +79,7 @@
7979
"minimatch": "^3.0.4",
8080
"mixin-deep": "^1.3.2",
8181
"moment": "2.24.0",
82-
"node": "14.20.1",
82+
"node": "20.8.1",
8383
"node-uuid": "^1.4.8",
8484
"open": "^8.4.0",
8585
"qs": "^6.10.2",

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -8798,10 +8798,10 @@ node.extend@^1.0.10:
87988798
has "^1.0.3"
87998799
is "^3.2.1"
88008800

8801-
node@14.20.1:
8802-
version "14.20.1"
8803-
resolved "https://registry.yarnpkg.com/node/-/node-14.20.1.tgz#09e5d4a06d48fdcbeca1ec1ae10bbe02901d36b9"
8804-
integrity sha512-X+ds8FIkd5O+o6uuZKjP8ONH64PN8B+bsR2atkyx5anwruCPRyqHQRFQzG80Ymxv/lptRm3emXvvVpiMLl2qLg==
8801+
node@20.8.1:
8802+
version "20.8.1"
8803+
resolved "https://registry.yarnpkg.com/node/-/node-20.8.1.tgz#fc2da9cbe07986a67c753072b258d139de1e4d0f"
8804+
integrity sha512-gG+nhijBgjTNjgPB4BxKaBKnFS49bngOuxw1/jVh4vlscg/6K+00n+2Q4LEnklTZJXFUQM+AqyGdfvh9h1JknA==
88058805
dependencies:
88068806
node-bin-setup "^1.0.0"
88078807

0 commit comments

Comments
 (0)