Skip to content

Commit e8cd784

Browse files
author
Alberto Paro
committed
Removed inused urllib3 files and added timeout to connection_http.
1 parent ca4cb9e commit e8cd784

File tree

7 files changed

+12
-617
lines changed

7 files changed

+12
-617
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@
22
docs/_build
33
.*.swp
44
pyes/tests/.noseids
5+
.idea

pyes/connection_http.py

+11-10
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
from fakettypes import *
1515
import socket
1616
import urllib
17+
1718
__all__ = ['connect', 'connect_thread_local']
1819

1920
"""
@@ -55,10 +56,11 @@ def execute(self, request):
5556
headers.update(request.headers)
5657
s = requests.session()
5758
response = s.request(method=Method._VALUES_TO_NAMES[request.method],
58-
url="http://%s:%s%s" % (self.host, self.port, request.uri), params=request.parameters,
59-
data=request.body, headers=request.headers)
59+
url="http://%s:%s%s" % (self.host, self.port, request.uri), params=request.parameters,
60+
data=request.body, headers=request.headers, timeout=self.timeout)
6061
return RestResponse(status=response.status_code, body=response.content, headers=response.headers)
6162

63+
6264
def connect(servers=None, framed_transport=False, timeout=None,
6365
retry_time=60, recycle=None, round_robin=None,
6466
max_retries=3, basic_auth=None):
@@ -102,7 +104,7 @@ def connect(servers=None, framed_transport=False, timeout=None,
102104
Expects keys:
103105
* username
104106
* password
105-
107+
106108
round_robin: bool
107109
*DEPRECATED*
108110
@@ -114,8 +116,8 @@ def connect(servers=None, framed_transport=False, timeout=None,
114116
if servers is None:
115117
servers = [DEFAULT_SERVER]
116118
return ThreadLocalConnection(servers, framed_transport, timeout,
117-
retry_time, recycle, max_retries=max_retries,
118-
basic_auth=basic_auth)
119+
retry_time, recycle, max_retries=max_retries,
120+
basic_auth=basic_auth)
119121

120122
connect_thread_local = connect
121123

@@ -170,7 +172,6 @@ def __init__(self, servers, framed_transport=False, timeout=None,
170172

171173
def __getattr__(self, attr):
172174
def _client_call(*args, **kwargs):
173-
174175
for retry in xrange(self._max_retries + 1):
175176
try:
176177
return getattr(self._ensure_connection(), attr)(*args, **kwargs)
@@ -202,8 +203,8 @@ def connect(self):
202203
server = self._servers.get()
203204
log.debug('Connecting to %s', server)
204205
self._local.conn = ClientTransport(server, self._framed_transport,
205-
self._timeout, self._recycle,
206-
self._basic_auth)
206+
self._timeout, self._recycle,
207+
self._basic_auth)
207208
except (socket.timeout, socket.error):
208209
log.warning('Connection to %s failed.', server)
209210
self._servers.mark_dead(server)
@@ -212,6 +213,6 @@ def connect(self):
212213

213214
def close(self):
214215
"""If a connection is open, close it."""
215-
# if self._local.conn:
216-
# self._local.conn.transport.close()
216+
# if self._local.conn:
217+
# self._local.conn.transport.close()
217218
self._local.conn = None

pyes/urllib3/__init__.py

-13
This file was deleted.

0 commit comments

Comments
 (0)