Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/articles mobile: can't tap on inline link if it's also a glossary term #534

Open
bryceerobertson opened this issue Mar 7, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@bryceerobertson
Copy link
Member

Image

My best guess at a solution is to make it so that glossary definitions aren't attached to text which contains a link.

@bryceerobertson bryceerobertson converted this from a draft issue Mar 7, 2024
@bryceerobertson bryceerobertson added the bug Something isn't working label Mar 7, 2024
@melissasamworth
Copy link
Contributor

Oh gosh that's tricky. I can't think of a better solution than yours at the moment.

@mruwnik
Copy link
Collaborator

mruwnik commented Aug 21, 2024

would this only be on mobile, or in general?

@mruwnik
Copy link
Collaborator

mruwnik commented Aug 21, 2024

how about long tap?

@bryceerobertson
Copy link
Member Author

@mruwnik this is only a problem on mobile – because you can't hover on mobile

@bryceerobertson
Copy link
Member Author

@mruwnik is long tap on websites a thing??

@mruwnik
Copy link
Collaborator

mruwnik commented Aug 21, 2024

it could be - I vaguely recall that being supported, and if not it shouldn't be that hard to implement it. The main issue would be communicating that functionality to the user

@bryceerobertson
Copy link
Member Author

Yeah agreed. @melissasamworth any thoughts on how to communicate this to users?

@LeMurphant
Copy link
Collaborator

I don't think it matters much on desktop. Also, the content team has been attempted to find instances of this link + glossary and remove the link, so it should become less of a problem over time, but I still think that it should be fixed with a technical solution as well.

@bryceerobertson
Copy link
Member Author

@LeMurphant nice. Given that + since there doesn't seem to be any great technical solution I think this issue is low priority then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Todo
Development

No branches or pull requests

4 participants