Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TilePos world location is not aligned with the drawn location in the tiled helper #500

Closed
cbrown1234 opened this issue Dec 24, 2023 · 1 comment · May be fixed by #501
Closed

TilePos world location is not aligned with the drawn location in the tiled helper #500

cbrown1234 opened this issue Dec 24, 2023 · 1 comment · May be fixed by #501
Labels
wontfix This will not be worked on

Comments

@cbrown1234
Copy link

cbrown1234 commented Dec 24, 2023 •
edited
Loading

e.g. the following would return the world location ignoring the transform from here:

bevy_ecs_tilemap/examples/helpers/tiled.rs

Lines 378 to 383 in b08a5d9

transform: get_tilemap_center_transform(
&map_size,
&grid_size,
&map_type,
layer_index as f32,
) * Transform::from_xyz(offset_x, -offset_y, 0.0),

or in the TiledMapBundle and defaulting to the bottom left at 0,0.

tile_pos.center_in_world(grid_size, map_type)

resulting in the world position of the tile entity not aligning with the drawn location
cbrown1234 added a commit to cbrown1234/bevy_ecs_tilemap that referenced this issue Dec 24, 2023
@cbrown1234
Fix tiled helper map location propagation
60e92de 
fixes StarArawn#500
@cbrown1234 cbrown1234 mentioned this issue Dec 24, 2023
Open
@richchurcher richchurcher mentioned this issue Jan 3, 2024
Closed
@StarArawn StarArawn added the wontfix This will not be worked on label Feb 11, 2024
@StarArawn
Copy link
Owner

Keep in mind this is an example and not meant to be fully functional. As long as the examples look fine and render correctly that is good enough. I'm more than happy to help in the creation of a bevy_tiled crate.

@rparrett rparrett mentioned this issue Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tiled helper map location propagation cbrown1234/bevy_ecs_tilemap
2 participants
@StarArawn @cbrown1234