Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand FPS weapon attachment data #106

Open
2 of 3 tasks
alistair3149 opened this issue Feb 2, 2024 · 4 comments
Open
2 of 3 tasks

Expand FPS weapon attachment data #106

alistair3149 opened this issue Feb 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@alistair3149
Copy link
Contributor

alistair3149 commented Feb 2, 2024

Weapon attachments apply various modifiers to the equipped weapon. It would be helpful to include those data:

  • SWeaponZeroingParams for optics attachments (1180f00)
  • Add type (e.g. laser pointer) for underbarrel attachments
  • Add data from SWeaponModifierComponentParams for all attachments
@octfx octfx added the enhancement New feature or request label Feb 2, 2024
octfx added a commit that referenced this issue Mar 3, 2024
@octfx
Copy link
Member

octfx commented Mar 9, 2024

SWeaponModifierComponentParams now available under the weapon_modifier key.
image

octfx added a commit that referenced this issue Mar 9, 2024
@octfx
Copy link
Member

octfx commented May 3, 2024

Is the type task still open?

@alistair3149
Copy link
Contributor Author

Yes it is still open. The same information is available under description data but I am not sure if there is a more accurate data source other than relying on localization

@octfx
Copy link
Member

octfx commented May 4, 2024

I've checked the xml files, there does not seem to be a dedicated attribute marking laser pointers as such.
For now I'd argue that the description data is as good as it gets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants