-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing and validation of Getting started guides for Service Discovery #229
Comments
@jkonicki Hi, I am looking into this issue as my first issue. Can you further explain? |
@ZuraizAhmedShehzad The goal is have someone run through these two project guides on the Steeltoe website (as noted above for Eureka and Consul) to ensure they cover all aspects of setting up and working with these services. If you find any issues with them, to note them, and even better, create a PR that updates the guide. |
@jkonicki I managed to setup "Service Discovery with Eureka Server". I want to share some findings with you.
We can add much more clarity for user by asking him to add configurations and create controller on his own if Steeltoe Initializr is not scaffolding it for them. |
Thank you @ZuraizAhmedShehzad |
@jkonicki okay. I can create PR if my points stay valid. |
I think it might be better to update the guide to use the weatherforecast model and controller that are included with the templates rather than adding instructions around adding a ValuesController (I think that's from an older .NET project template). Are you talking about the IIS configuration? I think that was removed from Initializr... I'd be inclined to update this guide to use the current settings coming out of the Initializr (running the project directly) and that way we also avoid the need for IIS Express and get a cleaner implementation with less that can get in the way. |
@TimHess Perfect ! I will create a PR the way you have mentioned. |
We are looking for users to run through our Service Discovery getting started guide.
Please validate the guide above, create any issues, create a PR (if you can), and leave a comment about the work you completed.
Here is the directory listing for the guide markdown
The text was updated successfully, but these errors were encountered: