Update local build instructions and README #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ccheetham
commented
Jun 6, 2022
•
ccheetham
commented
- remove details of DocFX configuration; defer to DocFX docs
- rename main site configuration files to be main-site*.json
- provide a local Docker image to run DocFX as a convenience
- fixes Local Docker Build does not work #263
TimHess
reviewed
Jun 6, 2022
TimHess
previously approved these changes
Jun 6, 2022
|
Thanks @ccheetham! I'm going to try this out out after #265 and #264 have been merged. |
Merged
|
If this solves #263, can you link to it from the PR description, so it auto-closes on merge? |
|
Waiting on #264 |
|
@ccheetham Can you please go ahead and resolve the merge issues and verify this PR is still accurate? |
* remove details of DocFX configuration; defer to DocFX docs * rename main site configuration files to be main-site*.json * provide a local Docker image to run DocFX as a convenience
* remove details of DocFX configuration; defer to DocFX docs * rename main site configuration files to be main-site*.json * provide a local Docker image to run DocFX as a convenience
TimHess
force-pushed
the
ccheetham/update-local-build-readme
branch
from
5d4a0a8
to
75f943e
Compare
|
These updates will now be included with #312, along with GH actions to build on top |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.