You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context: Same root cause as the clippy CI issue in this batch: gas-regression.yml (Wasm size + gas cost regression checks) existed at the monorepo root with working-directory: ./contracts, and was not carried over by the repo split. It's currently dead in Stellar-inights and absent here.
Where:
.github/workflows/gas-regression.yml (new in this repo)
Reference: old version in Stellar-Insightss/Stellar-inights at the same path (adapt the working directory, it's now repo root)
What to do:
Recreate the workflow: build each crate to wasm32-unknown-unknown --release, record the .wasm size, and fail (or warn) if it grows beyond a threshold vs the previous run.
For each of the 10 crates, build to wasm32-unknown-unknown --release and record the resulting .wasm file size.
Store the baseline (e.g. commit sizes to a checked-in file, or use a CI cache keyed on the previous run) and fail/warn the PR if any crate's size grows beyond a threshold you pick (start with something like 10%, tune later).
Wasm size can swing for reasons unrelated to the PR's actual logic change (toolchain version bumps, dependency updates) -- make sure the workflow compares against a same-toolchain baseline, not an arbitrary historical number.
Context: Same root cause as the clippy CI issue in this batch:
gas-regression.yml(Wasm size + gas cost regression checks) existed at the monorepo root withworking-directory: ./contracts, and was not carried over by the repo split. It's currently dead inStellar-inightsand absent here.Where:
.github/workflows/gas-regression.yml(new in this repo)Stellar-Insightss/Stellar-inightsat the same path (adapt the working directory, it's now repo root)What to do:
wasm32-unknown-unknown --release, record the.wasmsize, and fail (or warn) if it grows beyond a threshold vs the previous run.Suggested approach:
gas-regression.ymlfromStellar-Insightss/Stellar-inightsrather than writing from scratch.wasm32-unknown-unknown --releaseand record the resulting.wasmfile size.Watch out for:
Definition of done:
.github/workflows/gas-regression.ymlexists and runs on PRs touching contract crates