Split Ratio Sum Validation

[Kingsman-99]

Description

Accepting split ratios that do not sum to exactly 100 % (or 10 000 basis points) silently causes either under-distribution or over-distribution of funds. The contract must enforce ratio integrity at invoice creation time.

Technical Context

In contracts/split/src/lib.rs, add a validate_ratios(ratios: &Vec<u32>) -> Result<(), SplitError> private function that sums the slice and compares to the constant BASIS_POINTS_TOTAL = 10_000u32 defined in types.rs. Call it from create_invoice before writing any storage. Return InvalidRatioSum error on mismatch.

Acceptance Criteria

• Ratios summing to less than 10 000 are rejected with InvalidRatioSum
• Ratios summing to more than 10 000 are rejected with InvalidRatioSum
• A ratio vec with one entry equal to 10 000 is accepted
• Empty ratio vec is rejected with a distinct EmptyRecipientList error
• Validation runs before any storage writes occur
• All CI checks (cargo build --target wasm32-unknown-unknown, cargo test, cargo clippy) pass and the branch has no merge conflicts

---

[josese424]

@josese424 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi Maintainer,
I'd really appreciate the opportunity to work on this issue. Having reviewed the acceptance criteria, I'm confident that I can submit a PR shortly after being assigned.
Kindly assign this issue to me.
Thank you!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @josese424 to this issue.

[Meet-hybrid]

@Meet-hybrid has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Can I work on this please?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Meet-hybrid to this issue.

[chi797]

@chi797 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I’m a smart contract and full-stack developer who turns complex ideas into secure, production-ready blockchain code.
With strong skills in Rust and Solidity, I build systems that are fast, safe, and built to last.
My experience with the Stellar SDK lets me ship real-world Web3 solutions that actually move value

ℹ️ Repo Maintainers: To accept this application, review their application or assign @chi797 to this issue.

[gelfecodes]

@gelfecodes has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hello, I investigated the issue in depth and reviewed the existing implementation. I’m confident in my approach and would be pleased to contribute a clean, well-tested fix.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @gelfecodes to this issue.

[Keengfk]

@Keengfk has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

i would love to work on this issue and summit a clean pr withing 1 days

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Keengfk to this issue.

[drips-wave]

Congratulations, @Keengfk! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on July 30, 2026.

🧑‍💻 @Keengfk: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

@Keengfk's PR #542 was approved and merged by @Kingsman-99.

🏆 @Keengfk: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (293 total points). Track your full progress on GrantFox.

👏 Great work, @Keengfk! Keep contributing to Stellar-split.

[drips-wave]

This issue has been completed by @Keengfk as part of the Stellar Wave Program's 7th Wave 🥳

😎 @Keengfk: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.