Skip to content

webhook_url accepts http:// despite README requiring HTTPS #69

Description

@Darkdruce

Summary

Validation accepts both http:// and https://, so webhook payloads (with merchant_id, amounts, tx hashes) can be delivered in cleartext.

Location

  • src/api/payments.rs:130
  • README API table states webhook_url must be a "Valid HTTPS URL".

Details & impact

Cleartext webhook delivery exposes signed event bodies and headers to on-path attackers and contradicts the documented contract.

Suggested fix

Reject http:// on the public network (allow only for local/testnet dev, gated by config), and align the README/OpenAPI.

Acceptance criteria

  • http:// webhook URLs are rejected in production.
  • Docs and code agree.

Metadata

Metadata

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardOfficial Campaign | FWC26Campaign: Official Campaign | FWC26apiHTTP API surface and handlersbugSomething isn't workingsecuritywebhooksWebhook subsystem

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions