From bf00a7487ccd52d4bbd70a25ccd9d5ccebd99016 Mon Sep 17 00:00:00 2001 From: Skylar Paul Date: Tue, 9 Jan 2018 18:24:16 -0500 Subject: [PATCH 1/3] Update redirect url as per PayBright PayBright advised that the old url will be deprecated some time in the future and that this url should be used going forward. --- app/models/solidus_paybright/configuration.rb | 2 +- spec/models/spree/payment_method/paybright_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/solidus_paybright/configuration.rb b/app/models/solidus_paybright/configuration.rb index 29d267f..71ae31e 100644 --- a/app/models/solidus_paybright/configuration.rb +++ b/app/models/solidus_paybright/configuration.rb @@ -7,7 +7,7 @@ def test_redirect_url attr_writer :live_redirect_url def live_redirect_url - @live_redirect_url ||= "https://app.healthsmartfinancial.com/checkout/appform.aspx" + @live_redirect_url ||= "https://app.paybright.com/checkout/appform.aspx" end attr_writer :test_api_endpoint diff --git a/spec/models/spree/payment_method/paybright_spec.rb b/spec/models/spree/payment_method/paybright_spec.rb index 7d9e939..68e2992 100644 --- a/spec/models/spree/payment_method/paybright_spec.rb +++ b/spec/models/spree/payment_method/paybright_spec.rb @@ -36,7 +36,7 @@ expect( payment_method.redirect_url(payment) ).to start_with( - "https://app.healthsmartfinancial.com/checkout/appform.aspx?x_account_id=api-key&x_amount=110.00&x_currency=USD&" + "https://app.paybright.com/checkout/appform.aspx?x_account_id=api-key&x_amount=110.00&x_currency=USD&" ) end end From a2e552553dcd3e287d41a707d5cb8674a423a5d0 Mon Sep 17 00:00:00 2001 From: Skylar Paul Date: Tue, 9 Jan 2018 18:25:00 -0500 Subject: [PATCH 2/3] Address RuboCop violations --- .rubocop.yml | 2 +- solidus_paybright.gemspec | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index bb02624..26f155c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -44,7 +44,7 @@ Performance/Count: Style/RaiseArgs: Enabled: false -Style/OpMethod: +Naming/BinaryOperatorParameterName: Enabled: false # We can use good judgement here diff --git a/solidus_paybright.gemspec b/solidus_paybright.gemspec index 6e40aa8..513ffb7 100644 --- a/solidus_paybright.gemspec +++ b/solidus_paybright.gemspec @@ -1,5 +1,3 @@ -# encoding: UTF-8 - $:.push File.expand_path('../lib', __FILE__) require 'solidus_paybright/version' @@ -22,16 +20,16 @@ Gem::Specification.new do |s| s.add_dependency 'typhoeus' s.add_development_dependency 'capybara' - s.add_development_dependency 'poltergeist' s.add_development_dependency 'coffee-rails' - s.add_development_dependency 'sass-rails' s.add_development_dependency 'database_cleaner' s.add_development_dependency 'factory_girl' + s.add_development_dependency 'mysql2' + s.add_development_dependency 'pg' + s.add_development_dependency 'poltergeist' s.add_development_dependency 'rspec-rails' s.add_development_dependency 'rubocop', '>= 0.38' s.add_development_dependency 'rubocop-rspec', '1.4.0' + s.add_development_dependency 'sass-rails' s.add_development_dependency 'simplecov' s.add_development_dependency 'sqlite3' - s.add_development_dependency 'mysql2' - s.add_development_dependency 'pg' end From af8bd68f3b985b2b973b72738cd8e1519dee90a7 Mon Sep 17 00:00:00 2001 From: Skylar Paul Date: Wed, 10 Jan 2018 11:52:51 -0500 Subject: [PATCH 3/3] Specify pg version since ActiveRecord requires <1.0, which was recently released. --- solidus_paybright.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solidus_paybright.gemspec b/solidus_paybright.gemspec index 513ffb7..c6eb603 100644 --- a/solidus_paybright.gemspec +++ b/solidus_paybright.gemspec @@ -24,7 +24,7 @@ Gem::Specification.new do |s| s.add_development_dependency 'database_cleaner' s.add_development_dependency 'factory_girl' s.add_development_dependency 'mysql2' - s.add_development_dependency 'pg' + s.add_development_dependency 'pg', '~> 0.21' s.add_development_dependency 'poltergeist' s.add_development_dependency 'rspec-rails' s.add_development_dependency 'rubocop', '>= 0.38'