Update idevice to fix retransmission and debug proxy issue jkcoxson/idevice#14

Author: hugeBlack

StikJIT/JSSupport/IDeviceJSBridgeDebugProxy.m

@@ -17,7 +17,7 @@
     command = debugserver_command_new([commandStr UTF8String], NULL, 0);
 
     char* attach_response = 0;
-    IdeviceFfiError* err = debug_proxy_send_command2(debugProxy, command, &attach_response);
+    IdeviceFfiError* err = debug_proxy_send_command(debugProxy, command, &attach_response);
     debugserver_command_free(command);
     if (err) {
         context.exception = [JSValue valueWithObject:[NSString stringWithFormat:@"error code %d, msg %s", err->code, err->message] inContext:context];

StikJIT/idevice/jit.c

@@ -18,20 +18,6 @@
 
 #include "jit.h"
 
-IdeviceFfiError* debug_proxy_send_command2(struct DebugProxyHandle *handle, struct DebugserverCommandHandle *command, char **response) {
-    IdeviceFfiError* err = debug_proxy_send_command(handle, command, response);
-    if(err) {
-        return err;
-    }
-    for(int i = 0; i < 10; ++i) {
-        if(*response) {
-            return err;
-        }
-        debug_proxy_read_response(handle, response);
-    }
-    return err;
-}
-
 void runDebugServerCommand(int pid, DebugProxyHandle* debug_proxy, LogFuncC logger, DebugAppCallback callback) {
     // enable QStartNoAckMode
     char *disableResponse = NULL;
@@ -61,7 +47,7 @@ void runDebugServerCommand(int pid, DebugProxyHandle* debug_proxy, LogFuncC logg
         }
 
         char *attach_response = NULL;
-        err = debug_proxy_send_command2(debug_proxy, attach_cmd, &attach_response);
+        err = debug_proxy_send_command(debug_proxy, attach_cmd, &attach_response);
         debugserver_command_free(attach_cmd);
 
         if (err) {
@@ -79,11 +65,12 @@ void runDebugServerCommand(int pid, DebugProxyHandle* debug_proxy, LogFuncC logg
         logger("Failed to create detach command");
     } else {
         char *detach_response = NULL;
-        err = debug_proxy_send_command2(debug_proxy, detach_cmd, &detach_response);
+        err = debug_proxy_send_command(debug_proxy, detach_cmd, &detach_response);
         debugserver_command_free(detach_cmd);
 
         if (err) {
-            logger("Failed to detach from process: %d", err);
+            logger("Failed to detach from process: %d", err->code);
+            idevice_error_free(err);
         } else if (detach_response != NULL) {
             logger("Detach response: %s", detach_response);
             idevice_string_free(detach_response);

StikJIT/idevice/jit.h

@@ -13,7 +13,6 @@
 typedef void (^LogFuncC)(const char* message, ...);
 typedef void (^DebugAppCallback)(int pid, struct DebugProxyHandle* debug_proxy, dispatch_semaphore_t semaphore);
 int debug_app(IdeviceProviderHandle* tcp_provider, const char *bundle_id, LogFuncC logger, DebugAppCallback callback);
-IdeviceFfiError* debug_proxy_send_command2(struct DebugProxyHandle *handle, struct DebugserverCommandHandle *command, char **response);
 int debug_app_pid(IdeviceProviderHandle* tcp_provider, int pid, LogFuncC logger, DebugAppCallback callback);
 
 #endif /* JIT_H */