Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should delivery filters be checked for noexcept-ness? #66

Open
eao197 opened this issue Sep 4, 2023 · 0 comments
Open

Should delivery filters be checked for noexcept-ness? #66

eao197 opened this issue Sep 4, 2023 · 0 comments
Assignees

Comments

@eao197
Copy link
Member

eao197 commented Sep 4, 2023

Delivery filters must not throw exceptions because they are called in noexcept context.

But delivery filteres aren't checked to be noexcept functors. Should this check be added to so_add_delivery_filter-family of methods (by using static_assert)?

It seems that this change may break compatibility with 5.8.0, so may be this change has to be postponed to 5.9?

@eao197 eao197 self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant