Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install on node 14 #55

Open
weepy opened this issue Dec 27, 2020 · 4 comments
Open

Can't install on node 14 #55

weepy opened this issue Dec 27, 2020 · 4 comments

Comments

@weepy
Copy link

weepy commented Dec 27, 2020

I get this with node v14.15.3 . I downgraded to node 10 and it was fine. Just saying as the README says its developed with LTS (which is node 14)

 npm i naudiodon

> [email protected] install /Users/jonahfox/dev/node_modules/ref
> node-gyp rebuild

  CXX(target) Release/obj.target/binding/src/binding.o
../src/binding.cc:222:43: error: too few arguments to function call, single argument 'isolate' was not specified
  bool persistent = info[3]->BooleanValue();
                    ~~~~~~~~~~~~~~~~~~~~~ ^
/Users/jonahfox/Library/Caches/node-gyp/14.15.3/include/node/v8.h:2858:3: note: 'BooleanValue' declared here
  bool BooleanValue(Isolate* isolate) const;
  ^
../src/binding.cc:253:38: error: too few arguments to function call, single argument 'context' was not specified
  size_t size = info[2]->Uint32Value();
@scriptorian
Copy link

Hi, the code that is failing to build isn't from naudiodon and no naudiodon dependencies include the ref module, so I don't believe that this problem is caused by this project. I found this which might be relevant: TooTallNate/ref#125. Does anything in the responses look useful to you?

@weepy
Copy link
Author

weepy commented Dec 27, 2020 via email

@scriptorian
Copy link

I have recently used 12 and 14, it has built fine for me recently in both versions. One difference is that I'm on Windows and haven't recently tried building on Linux, though another naudiodon user has successfully done so after fixing a small problem introduced by my recent move from nan to napi.
Your install appears to be trying to build [email protected] in your node_modules folder, which hasn't been updated for 3 years and that is likely to be the source of the install error. Can you tell what package that you are using is dependant on ref? I don't believe that it is naudiodon.

@weepy
Copy link
Author

weepy commented Dec 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants