Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design flaw: third party addons cannot be updated for guest users #100

Open
Ivshti opened this issue Sep 13, 2019 · 3 comments
Open

design flaw: third party addons cannot be updated for guest users #100

Ivshti opened this issue Sep 13, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@Ivshti
Copy link
Member

Ivshti commented Sep 13, 2019

because there's no API addonCollectionGet for guest users, third party addons cannot be updated

should be fixed long term

This can be resolved using the same algo we use to update official addons: https://github.com/Stremio/stremio-core/blob/master/src/state_types/models/context.rs#L140

We can just do another async call to get the latest thirdparty addon catalog, and update

@Ivshti Ivshti self-assigned this Sep 13, 2019
@Ivshti Ivshti added this to the v1.2 milestone Jan 3, 2020
@nklhtv nklhtv added good first issue Good for newcomers challenge labels Jun 8, 2022
@nklhtv
Copy link
Contributor

nklhtv commented Jun 8, 2022

There must be a last_modified field so we update addons only if they are older than a fixed duration, like 1 week.
a bit of a challenge could be to properly schedule the requests, because if we request all addons on app start that will cause the same issues board does.
How could we avoid requesting all addons on app start?
Should we auto-update ONLY the addons that are part of the community catalog?

@gmjimenezc
Copy link

Hello can I work on this?

@nklhtv
Copy link
Contributor

nklhtv commented Oct 27, 2022

It's not yet clear how exactly we want to implement it.
I suggest we keep the current update the official addons as and update the 3rd party addons based on the community catalog
both of those should be triggered when PullAddonsFromAPI action is dispatch, without using any timers or flags in the core

elpiel added a commit that referenced this issue Jun 14, 2024
Use library item progress for continue watching preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants