Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User auth fails because of bad manifest from addon #417

Open
elpiel opened this issue Jan 5, 2023 · 0 comments
Open

User auth fails because of bad manifest from addon #417

elpiel opened this issue Jan 5, 2023 · 0 comments

Comments

@elpiel
Copy link
Member

elpiel commented Jan 5, 2023

Consider

Deserialization errors can cause unexpected behaviour like not being able to login if e.g. an addon has a bad mainfest or library item has a bad field.

Consider adding special serde_with-like attributes to fields which may cause this issue, like:

  • BoolFromAny - like string: "true", "false", int: 0,1, bool: true, false, etc.
  • VecSkipError - for invalid addons - that indeed seems a must (re-adding the addon could update the manifest?)
  • BoolFromInt - for manifest.behaviorHints.configurable - I'm not so sure if this is the right way, as it will cause more cases we need to uphold
  • Array - Array of strings

For example, serde_aux - https://docs.rs/serde-aux/latest/src/serde_aux/field_attributes.rs.html#586-646

Example

mad manifest causes user authentication failure on android tv.

INVALID Error: manifest.behaviorHints.configurable: invalid type: string "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant