Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No videos found for this meta!" error if no behaviorHints.defaultVideoId present in the catalog reponse #462

Open
dexter21767-dev opened this issue Jun 3, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dexter21767-dev
Copy link
Member

dexter21767-dev commented Jun 3, 2023

if a catalog response doesn't contain behaviorHints.defaultVideoId a "No videos found for this meta!" appears.
Note: this issue concerns when the type is set to "movie" and doesn't really affect other types in a major way.

according to the sdk behaviorHints.defaultVideoId is a Meta Object property and not a Meta Preview Object property and shouldn't be present in the catalog response.
the behavior from the old core is;
1- use catalog.id to request meta data
2- use the meta.behaviorHints.defaultVideoId if present to send stream and subtitles requests, if not present default to meta.id

the current behavior from the new core is:
1- use catalog.id to request meta data
2 use catalog.behaviorHints.defaultVideoId to send stream and subtitles requests.
which means that the new core doesn't make use meta.id and meta.behaviorHints.defaultVideoId in any addon-related way. which makes them unuseful for addon developers.

imo this problem happened due to confusion between "Meta Objects" and "Meta Preview Object" or it might have been intentional to improve the speed by sending the meta and stream requests in parallel instead of waiting for the Meta response. and if that's the case please tell me to update the documentation.

the URL that should be accessed from stremio-web is: (the old core does access this url)
https://web.stremio.com/#/detail/movie/tt9362722/tt9362722
but instead it's accessing:
https://web.stremio.com/#/detail/movie/tt9362722

screenshot of the problem:
image

@dexter21767-dev dexter21767-dev added the bug Something isn't working label Jun 3, 2023
@dexter21767-dev
Copy link
Member Author

As a consequence, movies aren't accessible from the library. all movies, no matter which addon they were addon from (including cinemeta) show the "No videos found for this meta!".

steps to reproduce:
1- open a new incognito browser to avoid cache results.
2- open stremio-web and log in.
3- try to access any movie from the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants