Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailer Preview #533

Open
Mkdantas opened this issue Dec 9, 2023 · 3 comments
Open

Trailer Preview #533

Mkdantas opened this issue Dec 9, 2023 · 3 comments

Comments

@Mkdantas
Copy link

Mkdantas commented Dec 9, 2023

There isn't an option for trailer preview like most streaming services when you are hovering through their library.
I tried implementing it, however, this is my first issue ever, please provide me with feedback and guide me on changes i should make if possible.

Trailer preview)

I used the ytId to embed a youtube video, however, if there is a way to serve the video id like how it is provided in metaDetails i could use stremio's player instead of youtube to show a preview of the trailer.

this is my fork with the above updates committed https://github.com/Mkdantas/stremio-web

@Iheuzio
Copy link
Contributor

Iheuzio commented Dec 9, 2023

An alternative could be to use the same trailer url and serve that video.

@Mkdantas
Copy link
Author

Mkdantas commented Dec 9, 2023

An alternative could be to use the same trailer url and serve that video.

Yeah, do you know how I can get that url to be in metaItem props? The trailer url present in metaDetail is not present in metaItem

@Iheuzio
Copy link
Contributor

Iheuzio commented Dec 9, 2023

An alternative could be to use the same trailer url and serve that video.

Yeah, do you know how I can get that url to be in metaItem props? The trailer url present in metaDetail is not present in metaItem

Nevermind, I see what you're trying to achieve. Its a pretty cool implementation, however for actual general use it would be best to leave the embeded players in their own window, thus the trailer pane is fine as is.

On mobile this wouldn't work, nor android tvs. It would create a navigation problem for the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants