Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy support issues and 404 page #534

Open
Iheuzio opened this issue Dec 10, 2023 · 1 comment
Open

Fix legacy support issues and 404 page #534

Iheuzio opened this issue Dec 10, 2023 · 1 comment

Comments

@Iheuzio
Copy link
Contributor

Iheuzio commented Dec 10, 2023

Issues

404 Page

  • 404 page is tracked by the entire website when we can just use a fallback
  • 404 page does not have a navbar for the other menus, just a back button
  • CSS is not positioned correctly, so content is not centered properly

Internet explorer support

  • There are some tags that could break support on older browsers entering the client, resolved many of the issues with the selectors

Express

  • Revalidation for caching

HTML

  • Add in missing header information

Images

  • Images were all draggable, causing an issue on certain pages, such as 404
    image

Things to Note

  • Posters use medium format, causing CRP and DOM issues when constructing certain pages (discovery and main). Trying to solve it when tracking onLoad with one of previous commits works to render everything without the images, which speeds up constructing the DOM for the discovery page greatly. However, I ran into issues on the Main page, so there's a possible solution in there.
@Iheuzio
Copy link
Contributor Author

Iheuzio commented Dec 10, 2023

The commit for the onLoad was 9d9053b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant