Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message in past builds too short #703

Open
oliversalzburg opened this issue Jan 26, 2015 · 8 comments
Open

Commit message in past builds too short #703

oliversalzburg opened this issue Jan 26, 2015 · 8 comments
Labels

Comments

@oliversalzburg
Copy link
Member

I just pulled the latest version of Strider from git and the commit messages in the Past Builds list seems a bit short:

This is in Chrome Stable

@knownasilya knownasilya added the ui label Jan 26, 2015
@knownasilya
Copy link
Member

How big is your resolution? At what point are they too short (px)?

@oliversalzburg
Copy link
Member Author

I'm on 2560x1440. This is in a maximized window. Here is a screenshot of the complete panel:

#build-page #list-of-builds .truncate is set to max-width: 110px;

@oliversalzburg
Copy link
Member Author

@knownasilya I also noticed that the past builds list no longer indicates if a particular build failed. Was that an intentional change?

@knownasilya
Copy link
Member

Nope, it should. There are several bugs around sockets, which have yet to be tracked down. Although I haven't noticed any issues with failed builds not showing up in the "past builds" section.

@oliversalzburg
Copy link
Member Author

Well, they do show up. It's just that you don't have an indicator that that particular build failed, until you select it and you get the red background.

@knownasilya
Copy link
Member

Yes, that's a bug, just checked and the icon class isn't coming through.

@oliversalzburg
Copy link
Member Author

@knownasilya Let me know if you want me to file a separate issue for that.

@knownasilya
Copy link
Member

@oliversalzburg pushed up a fix for the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants