Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: does this library allow using gradle v3.3.2 and variants? #12

Open
AndroidDeveloperLB opened this issue Apr 11, 2019 · 4 comments

Comments

@AndroidDeveloperLB
Copy link

It was told in the past that it's not:
https://github.com/StringCare/GradlePlugin/wiki/Plugin-Implementation

But there is a new version 1.2 .

Is this still an issue?

@efraespada
Copy link
Member

Of course you can use variants, the plugin will look for any XML file with string resources. You can also specify different string file names (by default is strings.xml).

I noticed com.android.tools.build:3.3.0 didn't work properly and 3.1.2 version worked fine at compilation time, so I don't know if it has been fixed in 3.3.2 version.

Have you tried it?

@efraespada efraespada transferred this issue from StringCare/AndroidLibrary Apr 11, 2019
@AndroidDeveloperLB
Copy link
Author

I tried to update to the new version, but for some reason it got me this: StringCare/AndroidLibrary#43 (comment) .

The weird thing:
When using version 0.9 of this repository, even though my gradle version is 3.3.2 , it works fine on my laptop (with Windows OS), yet on my colleague's laptop (macbook), it fails , and he keep telling me to use 3.2.1 instead ...

@efraespada
Copy link
Member

With SC v1.2 on macOS it fails with 3.2.1?

And on Windows with the same versions?

@AndroidDeveloperLB
Copy link
Author

v1.2 I tested only on Windows when using 3.3.2 version of gradle. It gave me the error I wrote about.

v0.9 was tested on both 3.2.1 and 3.3.2 versions of gradle. For some reason it works fine on my Windows OS laptop on both cases, yet on the macbook it worked fine on 3.2.1, and for a while on 3.3.2 (and now it doesn't)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants