Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reusability improvement: are NFDIDataset and NFDICatalog important classes ? #7

Open
markdoerr opened this issue Feb 12, 2025 · 1 comment
Open

reusability improvement: are NFDIDataset and NFDICatalog important classes ? #7

markdoerr opened this issue Feb 12, 2025 · 1 comment

Comments

@markdoerr
Copy link
Collaborator

In dcat_4nfdi_ap.yaml NFDIDataset and NFDICatalog are defined as subclasses of DCAT Dataset / Catalog.
Is this sub-classing really required ? What makes a Catalog or a Dataset so specifically a 'NFDI' dataset/catalog ?

I am asking, having future mappings in mind, which would require extra mappings for these subclasses.
Sub-classing should, to my opinion only be done, if there is a clear benefit.
@StroemPhi
Copy link
Owner

The subclassing is needed afaik in LinkML to further restrict the inherited slot like in this case the range of NFDIDataset.was_generated_by to be a ResearchActivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markdoerr @StroemPhi