Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent naming: params #239

Closed
aaronpeikert opened this issue Jan 31, 2025 · 1 comment
Closed

consistent naming: params #239

aaronpeikert opened this issue Jan 31, 2025 · 1 comment

Comments

@aaronpeikert
Copy link
Collaborator

aaronpeikert commented Jan 31, 2025

  • params should not longer return Vector[Symbol] but return values
  • param_values should be hence renamed and first suggestion was paramnames as a replacement for the old function
  • however there are other params functions such as: params_indices, and param_occourences, param_refs, should it be paramnames or param_names?
  • params is used as argument a couple of times, replace it with param(_)names there as well
  • params should work on AbstractSem not only on ParameterTable
  • the column param in parameter table must also be renamed
  • lavaan uses label so I think my preference would be param_label for the replacement function to be consistent with other functions and lavaan.
@Maximilian-Stefan-Ernst
Copy link
Collaborator

I would prefer param_labels, as the function to change a parameter's label in a StenoGraph specification is also called label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants