Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SourceCodeExpander miss rendering #193

Open
1 task done
E-vaTRON opened this issue Mar 25, 2024 · 0 comments
Open
1 task done

[Bug]: SourceCodeExpander miss rendering #193

E-vaTRON opened this issue Mar 25, 2024 · 0 comments

Comments

@E-vaTRON
Copy link
Collaborator

E-vaTRON commented Mar 25, 2024

Contact Details

[email protected]

What happened?

It happened in some SourceCodeExpander that have a complex string
In specific, it usually happens in properties that have a long and complex binding
for example:
in ActivityIndicator page (src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/ActivityIndicator)

that ActivityIndicator will generate into this string below
" <ActivityIndicator\r\n" +
" HorizontalOptions="Start"\r\n" +
" IsRunning="{x:Binding Source={x:Reference ActivityIndicatorSwitch},\r\n" +
" Path=IsToggled}"\r\n" +
" Color="{x:Binding Source={x:Reference ActivityIndicatorColorPicker},\r\n" +
" Path=SelectedItem,\r\n" +
" Converter={x:StaticResource StringToColorConverter}}" />"
the SourceCodeExpander will render all controls except the ActivityIndicator above will be rendered in black color text
image

some SourceCodeExpander have the same issue:
src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/Button
src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/MenuBar
src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/Picker
src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/ProgressBar

This also happened in wrong syntax coding
Like this one (src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Controls/MediaElement)
"<ContentPage\r\n" +
" x:Class="MAUIsland.MediaElementPage"\r\n" +
" xmlns="http://schemas.microsoft.com/dotnet/2021/maui\"\r\n" +
" xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml\"\r\n" +
""
image

the code above missing ">" at the end of the xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml\"

same as
src/Presentations/Windows/Features/Gallery/Pages/BuiltIn/Controls/Switch
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Controls/Expander
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/BoolToObjectConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/ByteArrayToImageSourceConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/ColorConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/CompareConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/CompareConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/DoubleToIntConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/EnumToBoolConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/EnumToIntConverter
src/Presentations/Windows/Features/Gallery/Pages/Toolkit/Converters/ImageResourceConverter

SourceCodeExpander can not read the color code too (src/Presentations/Windows/Features/Gallery/Pages/Community/Layouts/DataGrid)
image

Version

7.0

What platforms are you seeing the problem on?

Windows

Relevant log output

No response

Code of Conduct

  • I agree to respect and follow this project's rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant