Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coral.Manage build warnings #13

Open
pohlmf opened this issue Mar 8, 2024 · 2 comments
Open

Coral.Manage build warnings #13

pohlmf opened this issue Mar 8, 2024 · 2 comments

Comments

@pohlmf
Copy link

pohlmf commented Mar 8, 2024

Branch: dev
Commit: 9f071d7

When building Coral.Managed within my project, some build warnings are given (mainly about null references) that should be handled e.g. by error reporting, establishing default handling, etc.

Used tools:

  • cmake 3.25.1
  • Visual Studio Community 2022 64-bit (17.9.2)

BuildWarningsCoralManaged.txt

@VagueLobster
Copy link

You do know that Warnings != errors, right?
I don't see a problem here as long as Coral builds.

@pohlmf
Copy link
Author

pohlmf commented Mar 8, 2024

Yes, I know that warnings != errors :)
(with decades of experience as sw-dev and sw-arch in automotive and consumer-electronics industry and with hobby-projects)

Why I reported the warnings:

  • It is good practice to avoid build errors and warnings wherever possible (avoid future issues; think through your code once more; keep overview of errors/warnings in large projects)
  • Each build-warning may hint to a potential future runtime bug (here clearly the case at least for some null-reference warnings.
  • First level of defense; we even didn't start talking about static-code-analysis

Just wanted to help the project.
Whether or not the warnings will be fixed is actually your decision.
My recommendation would be to fix them.

Anyway, thanks for considering the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants