Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Linux users without Docker Desktop cannot build hook locally #40

Open
pauly4it opened this issue Aug 2, 2022 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@pauly4it
Copy link
Member

pauly4it commented Aug 2, 2022

For users who do not have Docker Desktop installed locally due to licensing issues, the cfn submit command cannot be run with the default Docker flow. Disabling the Docker option in the hook configuration and building the zip file on a non-Linux system results in Lambda function errors. The cfn cli does not currently officially support Docker alternatives.

I recommend running the cfn submit --dry-run command on an Ubuntu GitHub runner with Docker installed to generate a valid hook zip file.

@pauly4it pauly4it self-assigned this Aug 2, 2022
@pauly4it pauly4it added the enhancement New feature or request label Aug 2, 2022
@pauly4it
Copy link
Member Author

pauly4it commented Aug 5, 2022

We now have zip files generated and attached to workflow runs as artifacts. Next steps:

  1. Update README to mention the generated zip files and how to register a hook using the zip file
  2. Move to a versioned release flow similar to the OPA repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant