Update guiding flag enums - tickets/INSTRM-2799 #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors and enhances autoguider flag enums by renaming existing classes, adding a new matching flags enum, and improving documentation. The changes support the INSTRM-2799 ticket by modernizing the flag naming conventions to better reflect their purpose.
Key Changes:
- Renamed
AutoGuiderStarMask→SourceCatalogFlagsandSourceDetectionFlag→SourceDetectionFlags(plural) with deprecation warnings - Added new
SourceMatchingFlagsenum for catalog matching states - Enhanced all enums with zero-value entries, composite flag constants, and custom
__str__methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wtgee
force-pushed
the
tickets/INSTRM-2799
branch
from
d8904fc to
8a3fa48
Compare
* `AutoGuiderStarMask` changed to `SourceCatalogFlags`. * `SourceDetectionFlag` changed to `SourceDetectionFlags` (singular to plural). * Add deprecation warning for above. * Added `SourceMatchingFlags`. * Added `SourceDetectionFlags.BAD_SIZE`. * Updated docstrings. * Added bitmask of zero entries for the enums. * Added better `__str__` functions for the enums.
wtgee
force-pushed
the
tickets/INSTRM-2799
branch
from
8a3fa48 to
cb97f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoGuiderStarMaskchanged toSourceCatalogFlags.SourceDetectionFlagchanged toSourceDetectionFlags(singular to plural).SourceMatchingFlags.SourceDetectionFlags.BAD_SIZE.__str__functions for the enums.