dragonfly: Integrate staticcheck, fixed several errors pointed out by it and resolved others using directives.

Only U1000 was left for now, most of which are false positives from compiler directives.

Author: Sandertv

dragonfly/block/parse.go

@@ -1,5 +1,7 @@
 package block
 
+//lint:file-ignore ST1005 Errors returned by this file are intentionally readable for an end user.
+
 import (
 	"fmt"
 	"git.jetbrains.space/dragonfly/dragonfly.git/dragonfly/internal/block_internal"

dragonfly/block/register.go

@@ -109,13 +109,15 @@ func init() {
 
 // readSlice reads an interface slice from a map at the key passed.
 func readSlice(m map[string]interface{}, key string) []interface{} {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	v, _ := m[key]
 	b, _ := v.([]interface{})
 	return b
 }
 
 // readString reads a string from a map at the key passed.
 func readString(m map[string]interface{}, key string) string {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	v, _ := m[key]
 	b, _ := v.(string)
 	return b

dragonfly/entity/movement.go

@@ -23,10 +23,6 @@ type movementComputer struct {
 	dragBeforeGravity bool
 }
 
-// defaultGravity is the default gravity applied to entities.
-//noinspection GoUnusedConst
-const defaultGravity = 0.08
-
 // tickMovement performs a movement tick on an entity. Velocity is applied and changed according to the values
 // of its drag and gravity.
 // The new position of the entity after movement is returned.

dragonfly/internal/nbtconv/item.go

@@ -149,20 +149,23 @@ func readByte(m map[string]interface{}, key string) byte {
 
 // readInt16 reads an int16 from a map at the key passed.
 func readInt16(m map[string]interface{}, key string) int16 {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	v, _ := m[key]
 	b, _ := v.(int16)
 	return b
 }
 
 // readInt32 reads an int32 from a map at the key passed.
 func readInt32(m map[string]interface{}, key string) int32 {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	v, _ := m[key]
 	b, _ := v.(int32)
 	return b
 }
 
 // readString reads a string from a map at the key passed.
 func readString(m map[string]interface{}, key string) string {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	v, _ := m[key]
 	b, _ := v.(string)
 	return b

dragonfly/item/stack.go

@@ -59,7 +59,7 @@ func (s Stack) Grow(n int) Stack {
 	return s
 }
 
-// BaseDurability returns the current durability of the item stack. If the item is not one that implements the
+// Durability returns the current durability of the item stack. If the item is not one that implements the
 // Durable interface, BaseDurability will always return -1.
 // The closer the durability returned is to 0, the closer the item is to breaking.
 func (s Stack) Durability() int {

dragonfly/session/world.go

@@ -477,6 +477,7 @@ func (s *Session) blockRuntimeID(b world.Block) uint32 {
 // entityRuntimeID returns the runtime ID of the entity passed.
 func (s *Session) entityRuntimeID(e world.Entity) uint64 {
 	s.entityMutex.RLock()
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	id, _ := s.entityRuntimeIDs[e]
 	s.entityMutex.RUnlock()
 	return id

dragonfly/world/axis.go

@@ -17,7 +17,7 @@ const (
 	X
 )
 
-// EncodeBlock converts an Axis into either x, y or z, depending on which axis it is.
+// String converts an Axis into either x, y or z, depending on which axis it is.
 func (a Axis) String() string {
 	if a == X {
 		return "x"

dragonfly/world/position.go

@@ -54,11 +54,14 @@ func (p BlockPos) Side(face Face) BlockPos {
 	return p
 }
 
-// BlockPosFromNBT returns a position from the X, Y and Z components stored in the NBT data map passed. The
+// blockPosFromNBT returns a position from the X, Y and Z components stored in the NBT data map passed. The
 // map is assumed to have an 'x', 'y' and 'z' key.
-func BlockPosFromNBT(data map[string]interface{}) BlockPos {
+func blockPosFromNBT(data map[string]interface{}) BlockPos {
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	xInterface, _ := data["x"]
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	yInterface, _ := data["y"]
+	//lint:ignore S1005 Double assignment is done explicitly to prevent panics.
 	zInterface, _ := data["z"]
 	x, _ := xInterface.(int32)
 	y, _ := yInterface.(int32)

dragonfly/world/world.go

@@ -1035,7 +1035,7 @@ func (w *World) spreadLight(c *chunk.Chunk, pos ChunkPos) {
 // have block NBT will then be stored into memory.
 func (w *World) loadIntoBlocks(c *chunk.Chunk, blockEntityData []map[string]interface{}) {
 	for _, data := range blockEntityData {
-		pos := BlockPosFromNBT(data)
+		pos := blockPosFromNBT(data)
 		b, err := w.block(c, pos)
 		if err != nil {
 			w.log.Errorf("error loading block for block entity: %v", err)

staticcheck.conf

@@ -0,0 +1,10 @@
+checks = ["all", "-ST1000", "-ST1003", "-ST1016"]
+initialisms = ["ACL", "API", "ASCII", "CPU", "CSS", "DNS",
+	"EOF", "GUID", "HTML", "HTTP", "HTTPS", "ID",
+	"IP", "JSON", "QPS", "RAM", "RPC", "SLA",
+	"SMTP", "SQL", "SSH", "TCP", "TLS", "TTL",
+	"UDP", "UI", "GID", "UID", "UUID", "URI",
+	"URL", "UTF8", "VM", "XML", "XMPP", "XSRF",
+	"XSS", "XUID"]
+dot_import_whitelist = []
+http_status_code_whitelist = ["200", "400", "404", "500"]