Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer for RollCall #118

Closed
Swarnimashukla opened this issue Mar 22, 2021 · 15 comments · Fixed by #155
Closed

Footer for RollCall #118

Swarnimashukla opened this issue Mar 22, 2021 · 15 comments · Fixed by #155
Assignees
Labels
gssoc21 These issues are for GSSOC'21 participants Level1

Comments

@Swarnimashukla
Copy link
Owner

Check for issue #107 , wireframes and add elements accordingly.

Tech Stack : MERN Stack

@Swarnimashukla Swarnimashukla added gssoc21 These issues are for GSSOC'21 participants Level1 labels Mar 22, 2021
@Abhishekkr93
Copy link

I would like to contribute as a Gssoc21 participant. could you please assign me this? @Swarnimashukla

@Swarnimashukla
Copy link
Owner Author

@Abhishekkr93 what's the update regarding this task?

@Abhishekkr93
Copy link

@Swarnimashukla yes mam , I'm working on it but there is
my midsemm exam , so therefore delay in making pr. Can you please give me 2 days , I'll fix this.

@Abhishekkr93
Copy link

@Swarnimashukla hello mam, I am unable to find the codebase of the rollcall website, after that, I will fork, clone, add the code of the footer section.
please guide me! thank you.

@Swarnimashukla
Copy link
Owner Author

@Abhishekkr93 hey I have created a separate branch " Website" since there is no code for rollcall website as of now that's why you can't find any codebase , you may create your pr in "Website" branch keeping file name as "Rollcall_footer"

@Abhishekkr93
Copy link

Okay Ma'am. Thanks for update. I'll do that. @Swarnimashukla

@Abhishekkr93
Copy link

@Swarnimashukla ma'am,
I have some queries;

Can you please provide me all the social media profile links, I have to add in the footer section! The T&C page is not ready yet, so I left them the blank link, after this page is ready, I will add the link to the T&C page.

@Swarnimashukla
Copy link
Owner Author

For now keep everything blank only just include the icons in footer section for all social media links

@Abhishekkr93
Copy link

okay, mam, everything is done as per your requirement. here is a screenshot. can I make PR now? @Swarnimashukla
signal-2021-04-06-183043

@Swarnimashukla
Copy link
Owner Author

Ya please go for pr , just make sure you create pr in website branch and name it "RollCall_footer" with single commit @Abhishekkr93

@Abhishekkr93
Copy link

Okay mam!👍

@Abhishekkr93 Abhishekkr93 mentioned this issue Apr 6, 2021
5 tasks
@Abhishekkr93
Copy link

@Swarnimashukla done mam, have made PR #149 RollCall_footer. Kindly review and merge it.

@Swarnimashukla Swarnimashukla linked a pull request Apr 6, 2021 that will close this issue
5 tasks
@simranbhalla3
Copy link

I am a Gssoc participant , please assign me this issue.

@Avnish5
Copy link

Avnish5 commented Apr 7, 2021

@Swarnimashukla Kindly assign this task to me under GSSOC 2021.

@Abhishekkr93 Abhishekkr93 mentioned this issue Apr 8, 2021
5 tasks
@Abhishekkr93
Copy link

Abhishekkr93 commented Apr 8, 2021

@Swarnimashukla done mam, have made PR #155 RollCall_footer. Kindly review and merge it.

@Swarnimashukla Swarnimashukla linked a pull request Apr 8, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc21 These issues are for GSSOC'21 participants Level1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants