-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clude change language #1070
clude change language #1070
Conversation
Code Climate has analyzed commit a02967a and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding this option in hoem page. let's have it in the navigation drawer.
@@ -130,6 +130,6 @@ dependencies { | |||
}) | |||
} | |||
|
|||
preBuild.dependsOn('checkstyle') | |||
//preBuild.dependsOn('checkstyle') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
@@ -14,6 +14,8 @@ | |||
android:required="false" /> | |||
|
|||
<uses-permission android:name="android.permission.CAMERA" /> | |||
<uses-permission android:name="android.permission.CHANGE_CONFIGURATION" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is not needed for language change.
Bundle savedInstanceState) { | ||
|
||
View view = inflater.inflate(R.layout.change_language, container, false); | ||
button1 = view.findViewById(R.id.button1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have better naming for these?
@@ -135,9 +135,12 @@ public void onItemClick(int position) { | |||
break; | |||
case 7: | |||
setShowPageNumber(); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove changes in this file?
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
Description
I have added a button at the end of the application to jump to the language switching page.
Fixes #1065
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease
./gradlew checkstyle
Checklist: