Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSLocale localeWithLocaleIdentifier:]; #39

Open
nickasd opened this issue Mar 11, 2019 · 1 comment
Open

[NSLocale localeWithLocaleIdentifier:]; #39

nickasd opened this issue Mar 11, 2019 · 1 comment

Comments

@nickasd
Copy link

nickasd commented Mar 11, 2019

It should become Locale(identifier:).
http://swiftify.me/oza2f0

@alex-swiftify
Copy link
Member

Good suggestion, but this requires mapping of all NSLocale methods to Locale methods, as we currently do with NSArray/Dictionary/Set and a few other common types like NSURL.

I agree this is a positive change although NSLocale can be still used in Swift and this requires extensive testing to ensure that this change does not increase the error rate in the output.

JIRA issue: SWC-540 Review other class mappings that should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants