Don't check required rclone options with default values

Author: eikek

components/renku_data_services/storage/rclone.py

@@ -304,7 +304,10 @@ def validate_config(
             and self.exclusive
             and not any(e.value == str(value) and (not e.provider or e.provider == provider) for e in self.examples)
         ):
-            raise errors.ValidationError(message=f"Value '{value}' is not valid for field {self.name}")
+            valid_values = ", ".join([v.value for v in self.examples])
+            raise errors.ValidationError(
+                message=f"Value '{value}' is not valid for field {self.name}. Valid values are: {valid_values}"
+            )
         return cast(int | bool | dict | str, value)
 
 
@@ -323,7 +326,7 @@ class RCloneProviderSchema(BaseModel):
     @property
     def required_options(self) -> list[RCloneOption]:
         """Returns all required options for this provider."""
-        return [o for o in self.options if o.required]
+        return [o for o in self.options if o.required and not o.default]
 
     @property
     def sensitive_options(self) -> list[RCloneOption]:

test/components/renku_data_services/storage/test_rclone.py

@@ -0,0 +1,10 @@
+"""Tests for the rclone module."""
+
+from renku_data_services.storage.rclone import RCloneValidator
+
+
+def test_validate_switch_s3_no_endpoint() -> None:
+    """Endpoint has a default value and is not required to specify."""
+    validator = RCloneValidator()
+    cfg = {"provider": "Switch", "type": "s3"}
+    validator.validate(cfg, keep_sensitive=True)