Skip to content

Commit a313341

Browse files
committed
feat: use the amalthea session cache
1 parent 741b07e commit a313341

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

components/renku_data_services/notebooks/api/classes/k8s_client.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,13 @@ def __init__(self, url: str, server_type: type[_SessionType]):
351351
self.url = url
352352
self.client = httpx.AsyncClient()
353353
self.server_type: type[_SessionType] = server_type
354+
self.url_path_name = "servers"
355+
if server_type == AmaltheaSessionV1Alpha1:
356+
self.url_path_name = "sessions"
354357

355358
async def list_servers(self, safe_username: str) -> list[_SessionType]:
356359
"""List the jupyter servers."""
357-
url = urljoin(self.url, f"/users/{safe_username}/servers")
360+
url = urljoin(self.url, f"/users/{safe_username}/{self.url_path_name}")
358361
try:
359362
res = await self.client.get(url, timeout=10)
360363
except httpx.RequestError as err:
@@ -372,7 +375,7 @@ async def list_servers(self, safe_username: str) -> list[_SessionType]:
372375

373376
async def get_server(self, name: str) -> _SessionType | None:
374377
"""Get a specific jupyter server."""
375-
url = urljoin(self.url, f"/servers/{name}")
378+
url = urljoin(self.url, f"/{self.url_path_name}/{name}")
376379
try:
377380
res = await self.client.get(url, timeout=10)
378381
except httpx.RequestError as err:

components/renku_data_services/notebooks/blueprints.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -918,8 +918,8 @@ async def _handler(
918918
args=environment.args,
919919
shmSize="1G",
920920
env=[
921-
SessionEnvItem(name="RENKU_BASE_URL_PATH", value=base_server_url),
922-
SessionEnvItem(name="RENKU_BASE_URL", value=base_server_path),
921+
SessionEnvItem(name="RENKU_BASE_URL_PATH", value=base_server_path),
922+
SessionEnvItem(name="RENKU_BASE_URL", value=base_server_url),
923923
],
924924
),
925925
ingress=Ingress(

0 commit comments

Comments
 (0)