Skip to content

Commit 2ddc46d

Browse files
chore(service): rename /version to /apiversion (#2730)
Co-authored-by: Ralf Grubenmann <[email protected]>
1 parent 6569158 commit 2ddc46d

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

.github/workflows/test_deploy.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ jobs:
159159
run: |
160160
sudo apt-get update -y
161161
sudo apt-get install -y libyaml-0-2 libyaml-dev
162+
sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu impish main restricted multiverse universe"
163+
sudo apt-get update -y
164+
sudo apt-get install -y --allow-downgrades -t impish git-lfs=2.13.2-1
162165
- name: Install dependencies
163166
run: |
164167
python -m pip install --upgrade pip
@@ -205,6 +208,9 @@ jobs:
205208
run: |
206209
sudo apt-get update -y
207210
sudo apt-get install -y libyaml-0-2 libyaml-dev
211+
sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu impish main restricted multiverse universe"
212+
sudo apt-get update -y
213+
sudo apt-get install -y --allow-downgrades -t impish git-lfs=2.13.2-1
208214
- name: Install dependencies
209215
run: |
210216
python -m pip install --upgrade pip
@@ -436,6 +442,9 @@ jobs:
436442
run: |
437443
sudo apt-get update -y
438444
sudo apt-get install -y libyaml-0-2 libyaml-dev
445+
sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu impish main restricted multiverse universe"
446+
sudo apt-get update -y
447+
sudo apt-get install -y --allow-downgrades -t impish git-lfs=2.13.2-1
439448
- name: Install dependencies
440449
run: |
441450
python -m pip install --upgrade pip

renku/service/views/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
version_blueprint = VersionedBlueprint("version", __name__, url_prefix=SERVICE_PREFIX)
2525

2626

27-
@version_blueprint.route("/version", methods=["GET"], provide_automatic_options=False, versions=[V0_9])
27+
@version_blueprint.route("/apiversion", methods=["GET"], provide_automatic_options=False, versions=[V0_9])
2828
@handle_validation_except
2929
def version():
3030
"""

tests/cli/test_init.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -340,9 +340,8 @@ def test_init_with_parameters(isolated_runner, project_init, template):
340340
result = isolated_runner.invoke(
341341
cli, commands["init_test"] + commands["id"] + commands["parameters"], commands["confirm"]
342342
)
343-
assert 0 == result.exit_code
344-
assert "The template requires a value for" in result.output
345-
for param in set(template["metadata"].keys()):
343+
assert 0 == result.exit_code, result.output
344+
for param in ("p1", "p2"):
346345
assert param in result.output
347346
assert "These parameters are not used by the template and were ignored:" in result.output
348347

tests/service/views/test_version_views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_version(svc_client):
2424
"""Test expected response from version endpoint."""
2525
from renku import __version__
2626

27-
response = svc_client.get("/version")
27+
response = svc_client.get("/apiversion")
2828
assert "result" in response.json
2929
data = response.json["result"]
3030

@@ -36,7 +36,7 @@ def test_version(svc_client):
3636
assert MINIMUM_VERSION.name == data["minimum_api_version"]
3737
assert MAXIMUM_VERSION.name == data["maximum_api_version"]
3838

39-
response = svc_client.get("/0.9/version")
39+
response = svc_client.get("/0.9/apiversion")
4040
assert "result" in response.json
4141
data = response.json["result"]
4242

0 commit comments

Comments
 (0)