-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: fix some admin page modals, titles and content visual glitches #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-3894.dev.renku.ch |
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the vertical gutter |
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const customMarginStart = /\bms-(?:auto|[0-5])\b/.test(className ?? ""); | ||
| const customPaddingStart = /\bps-(?:auto|[0-5])\b/.test(className ?? ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say I do not like this conditional styling logic, it will be weird for the caller. I would rather remove the ms-1 and ps-2 props and let the caller set them.
|
Tearing down the temporary RenkuLab deplyoment for this PR. |


Some visual updates to the admin page to prevent modal overflow and use the current colors and titles
Before
After
Before
After
/deploy