Skip to content

Conversation

@lorenzo-cavazzi
Copy link
Member

Some visual updates to the admin page to prevent modal overflow and use the current colors and titles

Before

Screenshot_20251029_163744

After

Screenshot_20251029_164145

Before

Screenshot_20251029_164024

After

Screenshot_20251029_164048

/deploy

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner October 29, 2025 15:42
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3894.dev.renku.ch

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed here, but this could be fixed:

Image

@lorenzo-cavazzi
Copy link
Member Author

Not changed here, but this could be fixed:

Somehow the vertical gutter "gy-3" on the row inside the container is messing up with the top margin 🤔
I fixed it here 664cf8b -- the solution is not the most elegant (I force the column margin to 0 and add it to the container element) but it works 🤷

leafty
leafty previously approved these changes Nov 7, 2025
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 👍

Note: I think the collapse body left margin should be removed in this case. ms-1 works for this case:
Image

In the screenshot, the collapse section is a sub-section of the Code Repository field.

Here the advanced section is a whole section on its own.

Comment on lines +30 to +31
const customMarginStart = /\bms-(?:auto|[0-5])\b/.test(className ?? "");
const customPaddingStart = /\bps-(?:auto|[0-5])\b/.test(className ?? "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say I do not like this conditional styling logic, it will be weird for the caller. I would rather remove the ms-1 and ps-2 props and let the caller set them.

@lorenzo-cavazzi lorenzo-cavazzi merged commit f43511a into main Nov 11, 2025
32 of 33 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/fix-admin-modals branch November 11, 2025 09:40
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants