Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form not savable when event has long title #142

Open
1 task done
tyler-dane opened this issue Oct 2, 2024 · 3 comments
Open
1 task done

Form not savable when event has long title #142

tyler-dane opened this issue Oct 2, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tyler-dane
Copy link
Contributor

tyler-dane commented Oct 2, 2024

Prerequisites

  • Using an up-to-date main branch

Expected Behavior

Title/description in form is truncated, so that the user can still see, hover over, and click the Submit button

Current Behavior

Title takes up the entire view height, hiding the save button.
User can TAB until focus is on Save and type Enter (but no one does that).
Screen Shot 2024-10-02 at 6 41 20 AM

Steps to Reproduce

  1. Create event with long title

  2. Open event

  3. Notice: No save button viewable

Possible Solution (Not obligatory)

Some ideas:

  • Truncate the title using a lineClamp value, similar to how the event rectangle is doing the same on the grid/sidebar.
  • Instead of truncating based on the title, create a max line height based on the view height
  • See if there is some way to configure the minimum bottom padding for floating UI

Context

User is unable to easily save events because of this 💀

@tyler-dane tyler-dane added bug Something isn't working good first issue Good for newcomers labels Oct 2, 2024
@SuvineetSingh
Copy link

Hi @tyler-dane, can you assign this issue to me? I want to try solving this issue.

@tyler-dane
Copy link
Contributor Author

Hi @tyler-dane, can you assign this issue to me? I want to try solving this issue.

Sounds good!

@tyler-dane tyler-dane moved this from Todo to In Progress in v1 Cleanup Oct 3, 2024
@tyler-dane
Copy link
Contributor Author

Unassigned due to inactivity

@tyler-dane tyler-dane moved this from In Progress to Todo in v1 Cleanup Nov 28, 2024
@tyler-dane tyler-dane removed this from v1 Cleanup Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

2 participants