Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint version to v9 #149

Open
3 tasks
tyler-dane opened this issue Oct 7, 2024 · 0 comments
Open
3 tasks

Bump eslint version to v9 #149

tyler-dane opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tyler-dane
Copy link
Contributor

tyler-dane commented Oct 7, 2024

The current version of eslint is not supported. Let's get on the latest version.

https://eslint.org/version-support/

The warning:

warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

How to trigger the warning: run node build:

# running build
yarn cli build node                                                                 

# getting info
yarn run v1.22.22
$ export NODE_ENV=development && yarn ts-node  --pretty --transpile-only -r tsconfig-paths/register packages/scripts/src/cli build node
$ /Users/ty/src/switchback/compass/node_modules/.bin/ts-node --pretty --transpile-only -r tsconfig-paths/register packages/scripts/src/cli build node
? Select environment to use: (Use arrow keys)
❯ staging
? Select environment to use: production
? What package(s) do you want to build? nodePckgs
Removing old node build ...
Removed old node build
Env file does not exist: /Users/ty/src/switchback/compass/packages/backend/.prod.env
? Continue anyway? Yes

# running build
Continuing without env file ...
Copying package configs to build ...
Copied package configs to build
Compiling node packages ...
$ /Users/ty/src/switchback/compass/node_modules/.bin/tsc --project tsconfig.build.json
Compiled node pckgs
Installing dependencies...
info No lockfile found.
[1/4] Resolving packages...
warning @compass/backend > googleapis > google-auth-library > gtoken > [email protected]: Package is no longer maintained

# here's the warning 👇
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead

Acceptance Criteria

  • uses v9
  • no console warnings when building project
  • no other errors created
@tyler-dane tyler-dane added the enhancement New feature or request label Oct 7, 2024
@tyler-dane tyler-dane added the good first issue Good for newcomers label Oct 7, 2024
@tyler-dane tyler-dane removed this from v1 Cleanup Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

1 participant