Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the transaction_id to the payment details when completing the order? #251

Open
PILLOWPET opened this issue Jun 14, 2022 · 0 comments
Open

Add the transaction_id to the payment details when completing the order? #251

PILLOWPET opened this issue Jun 14, 2022 · 0 comments

Comments

@PILLOWPET
Copy link

Current problem

The CompleteOrderAction does not save the transaction id in the Payment details which makes it hard to correlate payment details in Sylius with transactions appearing in the Paypal dashboard.

Proposed solution

In CompleteOrderAction, persist the transaction_id which can be found under $orderDetails['purchase_units'][0]["payments"]["captures"][0]["id"]

I'd be happy to implement this
@PILLOWPET PILLOWPET mentioned this issue Jun 18, 2022
Merged
Zales0123 added a commit that referenced this issue Jul 14, 2022
@Zales0123
minor #252 add transaction id to payment details (PILLOWPET, Zales0123)
8529e65 
This PR was merged into the 1.4 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.3 (security fixes), 1.4 (bug fixes, improvements), master (new features)
| Bug fix?        | no
| New feature?    |yes
| Related tickets |  mentioned in #251 


Commits
-------

cda8150 add transaction id to payment details
2b447f3 Add spec for the new functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PILLOWPET