Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Remove final from controller #301

Open
migo315 opened this issue Oct 2, 2024 · 0 comments
Open

[Bug] Remove final from controller #301

migo315 opened this issue Oct 2, 2024 · 0 comments
Labels
Bug

Comments

@migo315
Copy link

migo315 commented Oct 2, 2024 •
edited
Loading

SyliusPayPalPlugin version affected: 1.6.0

Description
This plugin adds another method to the standard order item controller, but then sets it to Final.

This means that neither we nor any other plugin has the option of extending the controller itself.

final class PayPalOrderItemController extends OrderItemController.

Can't we remove the final here or put the PayPal logics in their own, separate controller?

Possible Solution

  • Remove final
  • Put PayPal Logics into own controller instead of extend Sylius standard controllers
@migo315 migo315 added the Bug label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@migo315