Improve perf ValidationExceptionListener

Author: Danny van Wijk

src/Bundle/Resources/config/services/listener.xml

@@ -22,8 +22,9 @@
         </service>
 
         <service id="sylius.listener.exception.validation" class="Sylius\Resource\Symfony\Validator\EventListener\ValidationExceptionListener">
-            <argument type="service" id="serializer" on-invalid="null" />
+            <argument type="service" id="service_container" />
             <tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" />
+            <tag name="container.service_subscriber" />
         </service>
     </services>
 </container>

src/Component/src/Symfony/Validator/EventListener/ValidationExceptionListener.php

@@ -13,19 +13,21 @@
 
 namespace Sylius\Resource\Symfony\Validator\EventListener;
 
+use Psr\Container\ContainerInterface;
 use Sylius\Resource\Symfony\Validator\Exception\ConstraintViolationListAwareExceptionInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\Serializer\SerializerInterface;
+use Symfony\Contracts\Service\ServiceSubscriberInterface;
 
 /**
  * Handles validation errors.
  *
  * @experimental
  */
-final class ValidationExceptionListener
+final class ValidationExceptionListener implements ServiceSubscriberInterface
 {
-    public function __construct(private ?SerializerInterface $serializer = null)
+    public function __construct(private ContainerInterface $container)
     {
     }
 
@@ -40,7 +42,9 @@ public function onKernelException(ExceptionEvent $event): void
             return;
         }
 
-        if (null === $this->serializer) {
+        /** @var SerializerInterface|null  $serializer */
+        $serializer = $this->container->get('serializer');
+        if (null === $serializer) {
             throw new \LogicException('The Symfony Serializer is not available. Try running "composer require symfony/serializer".');
         }
 
@@ -53,7 +57,7 @@ public function onKernelException(ExceptionEvent $event): void
         $mimeType = $request->getMimeType($format);
 
         $event->setResponse(new Response(
-            $this->serializer->serialize($exception->getConstraintViolationList(), $format),
+            $serializer->serialize($exception->getConstraintViolationList(), $format),
             Response::HTTP_UNPROCESSABLE_ENTITY,
             [
                 'Content-Type' => sprintf('%s; charset=utf-8', $mimeType),
@@ -62,4 +66,11 @@ public function onKernelException(ExceptionEvent $event): void
             ],
         ));
     }
+
+    public static function getSubscribedServices(): array
+    {
+        return [
+            'serializer' => '?' . SerializerInterface::class,
+        ];
+    }
 }