Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup aliases for sylius.resource_metadata_collection.factory.attributes service #776

Open
diimpp opened this issue Nov 7, 2023 · 0 comments

Comments

@diimpp
Copy link
Member

diimpp commented Nov 7, 2023

Service sylius.resource_metadata_collection.factory.attributes has two aliases

<service id="sylius.resource_metadata_collection.factory.attributes" class="Sylius\Component\Resource\Metadata\Resource\Factory\AttributesResourceMetadataCollectionFactory">
<argument type="service" id="sylius.resource_registry" />
<argument type="service" id="sylius.routing.factory.operation_route_name_factory" />
</service>
<service id="Sylius\Component\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface" alias="sylius.resource_metadata_collection.factory.attributes" />
<service id="sylius.resource_metadata_collection.factory" alias="sylius.resource_metadata_collection.factory.attributes" />

  1. How about making Sylius\Component\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface primary id and sylius.resource_metadata_collection.factory.attributes an alias.
  2. Deprecate at least one of the aliases or both
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant