Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update driver.py print message #241

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

donggook-me
Copy link
Contributor

Why are these changes needed?

beginner users might be confused by this printed message. Regardless of whether the process successfully work or not, it prints same message with log file path.

But when process doesn't work because of several each user's env reason, the error log just printed on the {job_name}_logging under root directory. So in this case they need to check this file.

Related issue number

Checks

  • I've included any doc changes needed for https://fedscale.readthedocs.io/en/latest/
  • I've made sure the following tests are passing.
  • Testing Configurations
    • Dry Run (20 training rounds & 1 evaluation round)
    • Cifar 10 (20 training rounds & 1 evaluation round)
    • Femnist (20 training rounds & 1 evaluation round)

beginner users might be confused by this printed message. Regardless of whether the process successfully work or not, it prints same message with log file path. 

But when process doesn't work because of several each user's env reason, the error log just printed on the {job_name}_logging under root directory. So in this case they need to check this file.
@fanlai0990
Copy link
Member

Thanks a lot for your contribution. :)

@fanlai0990 fanlai0990 merged commit a9ff1f0 into SymbioticLab:master Oct 16, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants