Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not obvious that all DnaComponents must be explicitly added to a collection #19

Open
Juul opened this issue Oct 14, 2011 · 0 comments
Open

Comments

@Juul
Copy link

Juul commented Oct 14, 2011

The xml format uses a flat list of all DnaComponents and then SequenceAnnotations refer back to that list, which makes sense in order to avoid repeating the same data, but it doesn't mirror the data model, and it is not obvious that you have to add all of the DnaComponents referred to in your SequenceAnnotations to your Collection manually. Right now, if you don't do this, the SequenceAnnotations that have subComponents not listed in the collection will only refer to the Component by URI, and upon deserialization you will realize that you have lost all other information about that Component.

I don't fell that the serializer should work like this. It should find all unique DnaComponents, whether they are in the Collection directly or only included as SubComponents, and it should compile a flat list of all of these, and then refer back from the SequenceAnnotations as it is doing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant