Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow to set the tag attribute on Postal messages #9

Open
a47ae opened this issue Jul 13, 2019 · 3 comments
Open

Feature: Allow to set the tag attribute on Postal messages #9

a47ae opened this issue Jul 13, 2019 · 3 comments
Labels
enhancement New feature or request on hold

Comments

@a47ae
Copy link

a47ae commented Jul 13, 2019

Postal allows to tag messages send via their API. This would be a useful feature to add to this package.

@williamrenfrew williamrenfrew added the enhancement New feature or request label Jul 13, 2019
@willpower232
Copy link
Member

This is an interesting idea, does Laravels MailMessage have any concept of tags or should we provide an interface to Postals SendMessage?

(an interface to Postals SendMessage may also be handy for custom headers for #8)

@a47ae
Copy link
Author

a47ae commented Jul 15, 2019

So I researched a bit how other popular mail driver packages handle this and I saw two solutions. The sendgrid package uses the embedData method on the Illuminate\Mail\Message class to provide custom data. This is, in my opinion, not the cleanest solution, but the other solution would require not using the Notification class, but rely on a custom class like the mailgun package does.

@Josh-G
Copy link
Contributor

Josh-G commented Jul 17, 2019

On hold for now due to outstanding issues in #8

@Josh-G Josh-G added the on hold label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold
Projects
None yet
Development

No branches or pull requests

4 participants