update: result messages

Update result message when config file not present

Author: sumits-systango

.gitignore

@@ -93,4 +93,7 @@ typings/
 
 ### Serverless ###
 # Ignore build directory
-.serverless
+.serverless
+
+##Apple
+.DS_store

controllers/pullRequest.js

@@ -44,10 +44,10 @@ module.exports.commitAndTitleValidator = async (app, context) => {
  * check Messages Format
  * @param {String} pullRequestTitle 
  * @param {Array} commits
- * @param {Object} prTitle
- * @param {Object} commitMsg
+ * @param {Object} prTitleRegex
+ * @param {Object} commitMsgRegex
  */
-function checkMessagesFormat(pullRequestTitle, commits, prTitle, commitMsg) {
+function checkMessagesFormat(pullRequestTitle, commits, prTitleRegex, commitMsgRegex) {
     try {
         let result = {};
         let commitIds = [];
@@ -60,12 +60,13 @@ function checkMessagesFormat(pullRequestTitle, commits, prTitle, commitMsg) {
         let commitMsgStatus = true;
         let commitMsgStatusMsg = messages.valid_commit_message;
         let outputTitle = outputTitleFail;
+        let output = {};
         /**
          * pull Request Title check : starts
          */
         // pull request title format
         let mergePattern = /^(Merge pull request)/;
-        if (checkRegex(pullRequestTitle, prTitle)) {
+        if (checkRegex(pullRequestTitle, prTitleRegex)) {
             pullReqTitleStatus = true;
             pullReqTitleStatusMsg = messages.valid_pull_request_message;
         } else {
@@ -86,7 +87,7 @@ function checkMessagesFormat(pullRequestTitle, commits, prTitle, commitMsg) {
                 const element = commits[index];
                 const commitMessage = element.commit.message;
                 commitIds.push(commits[index].sha);
-                if (!checkRegex(commitMessage, commitMsg) && !checkRegex(commitMessage, mergePattern)) {
+                if (!checkRegex(commitMessage, commitMsgRegex) && !checkRegex(commitMessage, mergePattern)) {
                     invalidCommitsCount++;
                     commitMsgStatus = false;
                     commitMsgStatusMsg = messages.invalid_commit_message;
@@ -114,11 +115,28 @@ function checkMessagesFormat(pullRequestTitle, commits, prTitle, commitMsg) {
             /**
              * set check run status
              */
-            let status = checkRunStatusCompleted;
-            let output = {
+            output = {
                 title: outputTitle,
-                summary: `${pullReqTitleStatusMsg}<br/>${commitMsgStatusMsg}<br/>${invalidCommits}<br/>${invalidCommitsCount} ${otherInvalidCommitMessages}`
+                summary: `${pullReqTitleStatusMsg}<br/>${commitMsgStatusMsg}<br/>${invalidCommits}<br/>`
             };
+            let status = checkRunStatusCompleted;
+            if ((!prTitleRegex || !prTitleRegex.regexPattern) && (!commitMsgRegex || !commitMsgRegex.regexPattern)) {
+                // pull request and commit message configration regex not set
+                output.title = `${messages.pr_and_commit_message_configuration_not_set}`;
+                output.summary = `${messages.pr_and_commit_message_configuration_not_set}<br/>`;
+            } else if (!commitMsgRegex || !commitMsgRegex.regexPattern) {
+                // commit message configration regex not set
+                output.title = `${messages.commit_message_configuration_not_set}`;
+                output.summary = `${pullReqTitleStatusMsg}<br/>${messages.commit_message_configuration_not_set}<br/>`;
+            } else if (!prTitleRegex || !prTitleRegex.regexPattern) {
+                // pull request configration regex not set
+                output.title = `${messages.pr_configuration_not_set}`;
+                output.summary = `${messages.pr_configuration_not_set}<br/>${commitMsgStatusMsg}<br/>${invalidCommits}<br/>`;
+            }
+            // set invalid commit messages and count
+            if (invalidCommitsCount && invalidCommitsCount >= defaultJson.INVALID_COMMIT_LIMIT) {
+                output.summary += `${invalidCommitsCount} ${otherInvalidCommitMessages}`;
+            }
             result = {
                 commitIds,
                 status,

default.json

@@ -13,16 +13,17 @@
         "valid_pull_request_message": "Pull request title is valid",
         "invalid_pull_request_message": "Pull request title is invalid",
         "multiple_other_invalid_message": "other messages are invalid",
-        "single_other_invalid_message": "other message is invalid"
+        "single_other_invalid_message": "other message is invalid",
+        "pr_configuration_not_set": "Pull request title format is not configured",
+        "commit_message_configuration_not_set": "Commit message format is not configured",
+        "pr_and_commit_message_configuration_not_set": "Pull request title and commit message format are not configured"
     },
     "CHECK_RUN_STATUS_COMPLETED": "completed",
     "CHECK_RUN_NAME": "commit message validator",
     "output_title_success": "Message validation passed!!!",
     "output_title_fail": "Message validation failed!!!",
-    "output_summary": "",
     "INVALID_COMMIT_LIMIT": 3,
     "USER_AGENT": "commit-message-validator-app",
-    "CONFIG_FILENAME": "validationconfig",
     "invalid_commit_list": {
         "commit_id": "sha:",
         "commit_message": "message:"

helpers/config.js

@@ -16,6 +16,7 @@ module.exports.getConfigData = async (app, owner, repository, fileName) => {
         let fileUrl = '';
         let fileDataString = '';
         searchFileResult = await searchFileInRepository(fileName, owner, repository);
+        app.log(searchFileResult);
         // files found
         if (searchFileResult && searchFileResult.items && Array.isArray(searchFileResult.items)) {
             for (let index = 0; index < searchFileResult.items.length; index++) {
@@ -49,6 +50,7 @@ module.exports.getRegexFromConfig = async (app, owner, repository, fileName) =>
             commitMsg: ''
         };
         let fileDataString = await exportObject.getConfigData(app, owner, repository, fileName);
+        app.log(fileDataString);
         let fileDataArray = fileDataString.split('\n');
         for (let index = 0; index < fileDataArray.length; index++) {
             const element = fileDataArray[index];