Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should all registers be pub? #2

Open
JuliDi opened this issue Jun 28, 2024 · 0 comments
Open

Should all registers be pub? #2

JuliDi opened this issue Jun 28, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JuliDi
Copy link
Member

JuliDi commented Jun 28, 2024

Currently almost everything is public. However, some register structs are only used internally (often just to implement the Reg trait with the address() function).
Maybe they should not be public. Or we move the set_* and get_* functions into the registers.

Suggestions and opinions welcome. This should be solved while still in beta.
@JuliDi JuliDi added enhancement New feature or request help wanted Extra attention is needed labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JuliDi