Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Excess Docker-Compose Configuration #222

Open
wesleyboar opened this issue Sep 1, 2023 · 1 comment
Open

Remove Excess Docker-Compose Configuration #222

wesleyboar opened this issue Sep 1, 2023 · 1 comment

Comments

@wesleyboar
Copy link
Member

Overview

We should be able to remove postgres and elasticsearch from Docker Compose configuration.

To Do

  1. Review feat: ecep_cms #184 (comment), feat: ecep_cms #184 (comment), feat: ecep_cms #184 (comment), and feat: ecep_cms #184 (comment).
  2. Determine which changes are safe and how to do them.
  3. Do it, and test each project.
@wesleyboar
Copy link
Member Author

Is this how I do that?

  1. Sync container docker-compose.dev.yml (from Core-CMS) to local files as docker-compose.core-cms.yml:

    docker-compose.dev.yml

        volumes:
          - ./docker-compose.core-cms.yml:/code/docker-compose.dev.yml
    
  2. Make postgres and elasticsearch services extend docker-compose.core-cms.yml:

    docker-compose.dev.yml

      postgres:
        extends:
          file: ../docker-compose.core-cms.yml
          service: postgres
    
      elasticsearch:
        extends:
          file: ../docker-compose.core-cms.yml
          service: elasticsearch
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant