test: add tests for TransactionNotifier
#317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-tbd
reviewed
Oct 16, 2024
Comment on lines
15
to
17
| class Listener<T> extends Mock { | ||
| void call(T? previous, T next); | ||
| } |
There was a problem hiding this comment.
think we can just move this to mocks.dart
ethan-tbd
reviewed
Oct 16, 2024
Comment on lines
29
to
33
| final pfi = TestData.getPfi('did:dht:pfiDid'); | ||
| const exchangeId = 'rfq_01ha835rhefwmagsknrrhvaa0k'; | ||
| final parameters = TransactionProviderParameters(pfi, exchangeId); | ||
|
|
||
| final did = TestData.aliceDid; |
There was a problem hiding this comment.
nit: let's move this to right below the await TestData.initializeDids()
ethan-tbd
reviewed
Oct 16, 2024
Comment on lines
+48
to
+57
| final container = createContainer( | ||
| overrides: [ | ||
| didProvider.overrideWith( | ||
| (ref) => did, | ||
| ), | ||
| tbdexServiceProvider.overrideWith( | ||
| (ref) => mockTbdexService, | ||
| ), | ||
| ], | ||
| ); |
There was a problem hiding this comment.
nice use of the createContainer() helper!
|
Thanks for the feedback! All comments have been addressed. |
ethan-tbd
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
TransactionNotifierclass.Closes #291.