Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unintended pathway for record updates that uses synchronizePrunedInitialRecordsWrite() #32

Open
frankhinek opened this issue Jun 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@frankhinek
Copy link
Collaborator

frankhinek commented Jun 1, 2023

PR #31 fixes a sync issue but does so in a way that RecordsWrite overwrites that mutate one of the 5 mutable properties other than data are unintentionally processed by the DWN SDK's synchronizePrunedInitialRecordsWrite() method.

Issue created to track follow-through with one of the two following changes:
1. dwn-sdk-js change would be to modify the synchronizePrunedInitialRecordsWrite() method signature to take as input a RecordsWrite message with no associated data && a RecordsDelete.
2. dwn-server and web5-js modification to introduce a new endpoint / RPC handler that is dedicated to sync so that RecordsWrite overwrites that mutate properties other than data don't flow through synchronizePrunedInitialRecordsWrite() unintentionally.

@frankhinek frankhinek changed the title Eliminate unintended pathway for record updates that uses synchronizePrunedInitialWrite Eliminate unintended pathway for record updates that uses synchronizePrunedInitialRecordsWrite() Jun 1, 2023
@frankhinek frankhinek mentioned this issue Jun 1, 2023
@frankhinek frankhinek added the enhancement New feature or request label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant